[GS-7591] Add new Step Slider component #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b1e4db6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JBezerra
requested review from
stellarhoof,
conraddavisjr,
positiveVibes4all,
PranitaJainB and
sandhya-spend
…l configs. Change babel file externsion
…l configs. Change babel file externsion
JBezerra
force-pushed
the
GS-7591/step-slider
branch
from
771d85a to
aff206b
Compare
There was a problem hiding this comment.
Outstanding work!
I owe you a review locally.
I was able to do due diligence and managed to leave feedback. Thanks @JBezerra!
packages/provider-elasticsearch/src/example-types/filters/step.test.js
Outdated
Show resolved
Hide resolved
| {/** This padding exists because of contexture native margins. | ||
| * When the slider thumb is encapsulated on the filter UI, | ||
| * part of it gets cut if no padding is applied. */} | ||
| <Box marginTop="6px" paddingX="11px"> |
There was a problem hiding this comment.
A request for em/rem over px
There was a problem hiding this comment.
What do you think about properly discussing that before moving forward with this change? My reason for that consideration is because we are using pixels as our measure everywhere on contexture and spark.
Doing this change in isolation wouldn't make sense if we are not willing to set that as our new standard from here and beyond. Other than that, that are other considerations we should do before starting using rem on a codebase founded in pixels.
There was a problem hiding this comment.
What about em? What are the repercussions of using that?
I might be missing something, but I don't see drawbacks specifically with em(?).
Also happy to discuss as a team. In fact, that could be more effective to tackle as a group,
v.s a siloed PR. 👍🏾
JBezerra
force-pushed
the
GS-7591/step-slider
branch
from
8b9ab9f to
e46381c
Compare
conraddavisjr
approved these changes
Aug 19, 2024
JBezerra
force-pushed
the
GS-7591/step-slider
branch
from
d87b453 to
16e9bbf
Compare
JBezerra
force-pushed
the
GS-7591/step-slider
branch
from
b7c9864 to
b2e80ce
Compare
JBezerra
force-pushed
the
GS-7591/step-slider
branch
from
0a7c29d to
8dbf2ef
Compare
|
Coverage after merging GS-7591/step-slider into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GS-7591
Before you start
A few things related to tooling were installed and configured so we can have better DX/reliability going forward:
In order to have better understanding how to link the changes of this PR to your local spark, please read the docs.
TL;DR Version
On Spark
On Contexture
On WebApp
Population Countfilter to your Spending page.Demo
2024-08-16.14-27-47.mp4
Context
As a Product Manager, I would like to have a more intuitive way for users to filter using Population Count in spending. Currently it is a range filter where users have to enter in a range to search. It would be nice if we could have pre-set population ranges for users to select and filter.
Start with preset ranges, below are the suggestions:
Acceptance Criterias: